fix(docs): make complex toolbar demo mobile-friendly - #110
Open
Atishyy27 wants to merge 1 commit into
Open
Conversation
move the control-button ToolbarItem into the existing ToolbarToggleGroup so that below the md breakpoint the left-aligned controls collapse into the overflow menu instead of overflowing the viewport. Fixes patternfly/patternfly-react#11708 Signed-off-by: Atishyy27 <sethatishayjain@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
problem
the complex toolbar demo doesn't collapse on small screens, so the toolbar overflows the viewport on mobile instead of moving controls into the overflow menu (see #11708).
root cause
the left controls are already wrapped in a ToolbarToggleGroup with breakpoint="md", but the control-button ToolbarItem sits outside that toggle group, so it stays visible at every width and keeps the toolbar wider than the viewport on mobile.
fix
move the control-button ToolbarItem inside the existing ToolbarToggleGroup, so below md all the left controls collapse into the overflow menu together. no new imports, desktop layout unchanged.
verification
rendered the demo at 390px, before vs after (below): before the control button stays in the bar; after it collapses into the ellipsis overflow so the toolbar fits. builds clean (tsc, 0 errors).
Fixes patternfly/patternfly-react#11708